CP-12315 completed and awaiting partial updates#63
Merged
ryanarakawa merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
* remove form name since we only add form name on creation and don't sync it to external API on edits * change copy to inform the user of the status of the form "Submitted", "Completed", or "Awaiting approval" * add DocuSeal attribution to awaiting status page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completedandawaitingpartials. The name is set on create and not synced on edits, so it can show inconsistent data.completedcopy to show "Submitted on {date} / Awaiting manager approval" whenrequires_approval: trueand not yet approved.completed.html.erbfor consistency with other statesBefore:
After - Awaiting Approval Status:
After - Awaiting other party to complete their side:
